Revert "[fix] Select Railway services when redeploying previews" - #4792
Conversation
dosubot
Bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.github.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de228efb8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if railway_call service "$service" >/dev/null 2>&1; then | ||
| railway_call redeploy --service "$service" --environment "$ENV_NAME" --yes >/dev/null | ||
| railway_call redeploy --yes >/dev/null |
There was a problem hiding this comment.
When the preview workflow runs deploy-from-images.sh, this helper is redeploying the requested infra service before Alembic, but a bare railway redeploy targets whatever service the CLI currently has linked; Railway’s redeploy reference says --service defaults to the linked service (https://docs.railway.com/cli/redeploy). This reintroduces the observed preview failure from #4725 where the linked service was gateway and the job failed with No deployment found for service before migrations/app deployment; the same bare-redeploy pattern is also restored in deploy-services.sh and smoke.sh.
Useful? React with 👍 / 👎.
Railway Preview Environment
|
1 participant
Reverts #4725